Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(verifyJWT): fix verification of JWT using EdDSA alg #142

Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix(verifyJWT): fix verification of JWT using EdDSA alg #142

merged 1 commit into from
Dec 8, 2020

Conversation

mirceanis
Copy link
Member

This fixes #141

All the core pieces were there, but there was a mismatch between the declared supported types and the actual supported types.

@mirceanis mirceanis requested a review from awoie December 8, 2020 16:16
@mirceanis mirceanis merged commit 12e2b88 into master Dec 8, 2020
@mirceanis mirceanis deleted the bugfix/141-EdDSA-verification branch December 8, 2020 16:21
uport-automation-bot pushed a commit that referenced this pull request Dec 8, 2020
@semantic-release-bot
chore(release): 4.7.1 [skip ci]
4190db6 
## [4.7.1](4.7.0...4.7.1) (2020-12-08)

### Bug Fixes

* **verifyJWT:** fix verification of JWT using EdDSA alg ([#142](#142)) ([12e2b88](12e2b88)), closes [#141](#141)
uport-automation-bot pushed a commit that referenced this pull request Dec 8, 2020
@semantic-release-bot
chore(release): 4.7.1 [skip ci]
aee8b5f 
## [4.7.1](4.7.0...4.7.1) (2020-12-08)

### Bug Fixes

* **verifyJWT:** fix verification of JWT using EdDSA alg ([#142](#142)) ([12e2b88](12e2b88)), closes [#141](#141)
uport-automation-bot pushed a commit that referenced this pull request Dec 8, 2020
@semantic-release-bot
chore(release): 4.7.1 [skip ci]
b78a63e 
## [4.7.1](4.7.0...4.7.1) (2020-12-08)

### Bug Fixes

* **verifyJWT:** fix verification of JWT using EdDSA alg ([#142](#142)) ([12e2b88](12e2b88)), closes [#141](#141)
uport-automation-bot pushed a commit that referenced this pull request Dec 8, 2020
@semantic-release-bot
chore(release): 4.7.1 [skip ci]
9320d74 
## [4.7.1](4.7.0...4.7.1) (2020-12-08)

### Bug Fixes

* **verifyJWT:** fix verification of JWT using EdDSA alg ([#142](#142)) ([12e2b88](12e2b88)), closes [#141](#141)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 4.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italobb italobb italobb approved these changes

@awoie awoie Awaiting requested review from awoie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] verifyJWT fails on JWT with EdDSA alg from issuer using a Ed25519VerificationKey2018 key
3 participants
@mirceanis @uport-automation-bot @italobb