-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt to did core spec #156
Conversation
f0b8274
to
ea67d98
Compare
ea67d98
to
aaaed1f
Compare
aaaed1f
to
c764860
Compare
Verifiers now have the ability to filter the types of `verificationMethod` used from the DID document based on purpose. Please replace the `auth: true` option with `proofPurpose: 'authentication'`
@oed now I think it's ready. please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a spec perspective although I think verificationRelationship is more appropriate than proofPurpose.
that's true, but it is so very verbose 😅 .. I guess |
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #155
added support for
blockchainAccountId
This PR introduces verification capabilities for DID documents that use
blockchainAccountId
(with eip155)Support for
ethereumAddress
is maintained for backward compatibility.added support for
proofPurpose
Verification can now be done using a
proofPurpose
, which filters theverificationMethod
based on the entries in the respective section of theDIDDocument
.Examples:
For backward compatibility the verifier supports legacy DID resolvers that do not return
DIDResolutionResult
and also DID Documents that do not listassertionMethod
at all.This support will be removed once the ecosystem is more uniform with compliance.
testing
This PR also includes some hardening of existing tests. Using
expect.assertions(...)
to make sure that async tests are not falsely passing and replaced some test assertions with stricter versions and sometoMatchSnapshot
withtoEqual