Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to latest did-core-spec #155

Closed
mirceanis opened this issue Mar 16, 2021 · 7 comments · Fixed by #156
Closed

Adapt to latest did-core-spec #155

mirceanis opened this issue Mar 16, 2021 · 7 comments · Fixed by #156
Assignees
@mirceanis
Labels
bug Something isn't working enhancement New feature or request feature

Comments

@mirceanis
Copy link
Member

This library is using some assumptions that no longer hold true against the latest did core spec.
More specifically, did resolution should now use:

  • DidResolutionResult instead of DIDDocument
  • verificationMethod instead of publicKey in the DIDDocument
  • and blockchainAccountId instead of ethereumAddress
@mirceanis mirceanis added bug Something isn't working enhancement New feature or request feature labels Mar 16, 2021
@mirceanis mirceanis self-assigned this Mar 16, 2021
@OR13
Copy link

OR13 commented Mar 16, 2021

This is excellent, thanks for capturing these changes... regarding blockchainAccountId, this may be helpful:

https://github.com/OR13/lds-blockchain2021

https://or13.github.io/lds-blockchain2021/#did-document

@OR13
Copy link

OR13 commented Mar 16, 2021

Also keep an eye on w3c/did-extensions#264

blockchainAccountId will stay, but probably the verification method types, like "EcdsaSecp256k1VerificationKey2019" will be removed from did core context in the future.

@mirceanis
Copy link
Member Author

Thank you. I will try to keep up. Although, the spec keeps getting more and more convoluted every time I look again 😅
Fortunetely, this library doesn't do any JSON-LD processing for now.

@oed
Copy link
Contributor

oed commented Mar 17, 2021

@OR13 What is BlockchainVerificationMethod2021 supposed to mean? Seems like this could potentially include a lot of different things depending on a variety of different factors?

@OR13
Copy link

OR13 commented Mar 18, 2021 •
edited
Loading

@oed its just something that uses blockchainAccountId... as far as I know, nobody was using blockchainAccountId yet.... see the spec... since blockchainAccountId can support bitcoin AND ethereum, etc.... the verification method type is very generic... you could easily limit it to just on chain type supported by blockchainAccountId if you wished.

@oed
Copy link
Contributor

oed commented Mar 18, 2021

Ok, blockchainAccountId definitely makes a lot of sense. Was just wondering how one would interpret a BlockchainSignature2021 for example :)

@mirceanis mirceanis mentioned this issue Mar 23, 2021
Merged
mirceanis added a commit that referenced this issue Mar 24, 2021
@mirceanis
feat: adapt to did core spec (#156)
4283ab3 
* feat: add support for blockchainAccountId (with eip155)
* test: add extra tests and assertion counts
* refactor: remove unused files and reformat
* fix: add support for legacy resolvers
* feat: introduce `proofPurpose` support during verification
* feat: add support for legacy DIDDocuments that do not list `assertionMethod` at all

Verifiers now have the ability to filter the types of `verificationMethod` used from the DID document based on purpose. Please replace the `auth: true` option with `proofPurpose: 'authentication'`

closes #155
uport-automation-bot pushed a commit that referenced this issue Mar 24, 2021
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
0cc59a3 
# [5.1.0](5.0.2...5.1.0) (2021-03-24)

### Features

* adapt to did core spec ([#156](#156)) ([4283ab3](4283ab3)), closes [#155](#155)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
bug Something isn't working enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adapt to did core spec decentralized-identity/did-jwt
4 participants
@mirceanis @oed @OR13 @uport-automation-bot