Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] use unified representation of key material #128

Closed
mirceanis opened this issue Aug 20, 2020 · 1 comment
Closed

[enhancement] use unified representation of key material #128

mirceanis opened this issue Aug 20, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mirceanis
Copy link
Member

As a prerequisite to fixing #127, this library needs to first transform public key material from DID docs to a unified representation that can later be converted to the needs of each verification method.

some code that will be affected:

const fullPublicKeys = authenticators.filter(({ publicKeyHex }) => {

let signer: PublicKey = fullPublicKeys.find(({ publicKeyHex }) => {

({ publicKeyHex, ethereumAddress }) =>

const signer: PublicKey = authenticators.find(({ publicKeyBase64 }) =>

@mirceanis mirceanis added the enhancement New feature or request label Aug 20, 2020
@mirceanis mirceanis self-assigned this Aug 20, 2020
uport-automation-bot pushed a commit that referenced this issue Nov 10, 2020
## [4.6.3](4.6.2...4.6.3) (2020-11-10)

### Bug Fixes

* support multiple pubkey encodings ([#139](#139)) ([c4ae63a](c4ae63a)), closes [#128](#128) [#127](#127)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants