Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new vector; update code for vectors besides gateways #161

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

decentralgabe
Copy link
Member

@decentralgabe decentralgabe commented Apr 2, 2024

updates results of #148 and #155
adds a new vector that should've been added with #148

@decentralgabe decentralgabe marked this pull request as ready for review April 2, 2024 22:49
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.93443% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 55.33%. Comparing base (a8b8917) to head (6dcea61).

Files Patch % Lines
impl/internal/did/did.go 65.48% 32 Missing and 7 partials ⚠️
impl/internal/did/client.go 57.14% 3 Missing ⚠️
impl/concurrencytest/main.go 0.00% 1 Missing ⚠️
impl/integrationtest/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   54.05%   55.33%   +1.28%     
==========================================
  Files          29       29              
  Lines        2146     2230      +84     
==========================================
+ Hits         1160     1234      +74     
- Misses        872      879       +7     
- Partials      114      117       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decentralgabe
Copy link
Member Author

merging for agility; open to post-merge feedback

@decentralgabe decentralgabe merged commit f792c43 into main Apr 2, 2024
5 checks passed
@decentralgabe decentralgabe deleted the uptake-spec-changes branch April 2, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants