Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address misc spec updates #146

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Address misc spec updates #146

merged 5 commits into from
Mar 22, 2024

Conversation

decentralgabe
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 53.84%. Comparing base (e2db0ba) to head (044e474).

Files Patch % Lines
impl/internal/did/did.go 52.63% 13 Missing and 5 partials ⚠️
impl/internal/cli/store.go 0.00% 8 Missing ⚠️
impl/concurrencytest/main.go 0.00% 4 Missing ⚠️
impl/pkg/service/pkarr.go 70.00% 2 Missing and 1 partial ⚠️
impl/pkg/dht/dht.go 0.00% 2 Missing ⚠️
impl/internal/did/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   54.27%   53.84%   -0.43%     
==========================================
  Files          29       29              
  Lines        2119     2134      +15     
==========================================
- Hits         1150     1149       -1     
- Misses        862      873      +11     
- Partials      107      112       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decentralgabe decentralgabe merged commit 5176956 into main Mar 22, 2024
4 of 5 checks passed
@decentralgabe decentralgabe deleted the update-impl branch March 22, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants