Update did-core-v1 context #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
reviewed
Nov 22, 2021
| @@ -1,7 +1,24 @@ | |||
| { | |||
| "@context": [ | |||
| "https://www.w3.org/ns/did/v1", | |||
| "https://identity.foundation/EcdsaSecp256k1RecoverySignature2020/lds-ecdsa-secp256k1-recovery2020-0.0.jsonld" | |||
| "https://identity.foundation/EcdsaSecp256k1RecoverySignature2020/lds-ecdsa-secp256k1-recovery2020-0.0.jsonld", | |||
There was a problem hiding this comment.
seems better to fix these issue in the context, potentially also swiching to a w3id.org redirect
There was a problem hiding this comment.
#24 should enable removing these inline definitions. (Except for publicKey which is legacy and this document should probably be changed to use verificationMethod instead.)
OR13
approved these changes
Nov 22, 2021
Define removed terms in DID document local context, to preserve existing structure.
|
Rebasing and merging. |
clehner
force-pushed
the
fix/did-core-v1-cr
branch
from
4f14562
to
8fb1ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the repo's local copy of the DID Core v1 context, according to DID Core's Candidate Recommendation: w3c/did-extensions#277.
I updated the test DID document to define terms in the local context that are no longer defined in DID Core, to preserve the existing data structure. The signatures on the DID document don't actually appear to be verified in the tests, but the N-Quads can be compared using JSON-LD Playground: