Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opti: textures compression #2568

Open
wants to merge 265 commits into
base: dev
Choose a base branch
from
Open

Opti: textures compression #2568

wants to merge 265 commits into from

Conversation

NickKhalow
Copy link
Collaborator

What does this PR change?

Integrated custom image decoder. It reduced memory usage up to 20% because standard UnityWebRequestTexture.GetTexture won't support any compression. Decoder uses ASTC (general purpose) and BC5 formats. It brought a support for Jpeg, Png, and extra WebP, Tif, Gif. SIMDe library is integrated since Compressonator won't support arm64 out of box

How to test the changes?

  1. Play Happy path
  2. Experience better performance

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

# Conflicts:
#	Explorer/Assets/DCL/InWorldCamera/CameraReelStorageService/Playground/CameraReelRemoteServicesManualTest.cs
#	Explorer/Assets/DCL/MapRenderer/MapLayers/Atlas/SatelliteAtlas/SatelliteChunkController.cs
#	Explorer/Assets/DCL/MapRenderer/MapRenderer.asmdef
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
#	Explorer/Assets/DCL/Tests/PlayMode/DCL.PlayMode.Tests.asmdef
#	Explorer/Assets/Scripts/Global/Dynamic/BootstrapAnalyticsDecorator.cs
#	Explorer/Assets/Scripts/Global/Dynamic/BootstrapContainer.cs
#	Explorer/Assets/Scripts/Global/Dynamic/Bootstraper.cs
#	Explorer/Assets/Scripts/Global/Tests/PlayMode/IntegrationTestsSuite.cs
@DafGreco DafGreco self-requested a review November 21, 2024 10:18
Copy link
Collaborator

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Windows and macOS ✅

Copy link
Collaborator

@m3taphysics m3taphysics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to validate memory usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-build Used to trigger clean build on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory: Compress and Resize Textures
7 participants