Improve web_api plugin #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mimoja
approved these changes
Apr 14, 2021
|
|
||
| start_idle | ||
| proc ::wibble::return_200_json {{content "{status: ok}"}} { |
There was a problem hiding this comment.
Something seems a bit off with your whitespaces here
There was a problem hiding this comment.
New code: Single tab indentation, consistent with much of the de1app Tcl code I've worked with.
start_idle: 4 spaces
We probably should come up with a standard (my preference including no trailing whitespace and each file ends with a newline with no blank lines)
I can see arguments for or against spaces/tabs and 4/8-column indentation
By moving the declarations into main, it now "does nothing" if not enabled.
Make extension of command set easier with utilties:
proc ::wibble::return_200_json {{content "{status: ok}"}}
proc ::wibble::return_200_text {{content "ok"}}
Signed-Off-By: Jeff Kletsky <[email protected]>
Use the settings value instead of being hard-coded to 8080 Signed-Off-By: Jeff Kletsky <[email protected]>
|
Corrected MIME type on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a priority for v1.35
As noted in #73 the web_api plugin previously created and used the
::wibblenamespace, even if the plugin was not enabled. Resolved by moving theproc ::wibble::*definitions intomain {}Seeing duplication of the generation the response object and expecting to add to the API, made generalized "200" returns for JSON and text data.
In resolving that, noted that the port was hard-coded.
Added a /flush action, which calls
::logging::flush_log(Introduced by #114, not merged at this time).