Skip to content

Commit

Permalink
scale: Remove redundant scale-timer reset from vars.tcl
Browse files Browse the repository at this point in the history
Scales that have a timer and have ::device::scale::use_timer True
will have their timer reset on entering a flow state, such as Espresso.

Code in vars.tcl would also call ::scale_timer_reset on resetting the
espresso timers, typically at the start of flow.

At the start of flow, a timer-start command is sent. This often
immediately after the timer-clear command from vars.tcl. There is some
evidence that scale hardware may not gracefully handle tight timing.

Rather than introduce a delay, remove the redundant call in vars.tcl

Signed-Off-By: Jeff Kletsky <[email protected]>
  • Loading branch information
jeffsf authored and Mimoja committed Apr 14, 2021
1 parent 2a26b6c commit 2efe5dd
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions de1plus/vars.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,6 @@ proc clear_espresso_timers {} {
set ::timers(espresso_pour_stop) 0

set ::timer_running 0

catch {
scale_timer_reset
}
}

clear_espresso_timers
Expand Down

0 comments on commit 2efe5dd

Please sign in to comment.