-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #674
Update dependencies #674
Conversation
You'll notice a TON of files changed and that's because I renamed all the CSS files to SCSS. Especially because many of these files were using Sass it made more sense to rename them. Before, they were just silently failing. Happy to discuss any of these changes more. |
Found through Sass documentation on @import https://sass-lang.com/documentation/at-rules/import
this may just be my machine but whenever i run this could be solved by setting dev settings in the |
Hmmm... I can't seem to reproduce this effect @tzmanics. It could be a timing issue where the build of the HTML finishes first before the CSS is ready and maybe it is a flash unstyled content. Can you try deleting it and trying it again, maybe after installing dependencies let yarn start wait a bit and if nothing happens just refresh the browser page to see if it flashes the content? |
If you never see it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IT WORKS!!!!!
Super interesting! I think I need to downgrade React no matter what because I suspect the lockfile has the right version needed but if you try to swap package managers it might end up breaking. Thank you for testing this @taty2010! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is probably not meant to be committed.
Summary
This project had many versions of dependencies to update so this works to make sure everything is up to date as possible. In the process of doing that we are now on Webpack 5 which should afford quite a huge speed boost.
We've also made sure to utilize the NetlifyCMS through the CDN as opposed to a dependency. This follows more to the patterns established on <netlifycms.org>. The package updates also had a huge amount of inspiration from the previous work we did on victor-hugo from a previous colleague.
A notable upgrade that we had to do is also replace
node-sass
as it is now through the Dart implementation undersass
. This at the surface doesn't change any APIs but the internals are significantly different and require the correct bindings for the project.Test Plan
For the deploy preview:
+hugo
somewhere in your email before@
so you can filter it out later if you'd like./admin
under the deploy previewFor local development:
ntl dev
static/admin/config.yml
underbackend
, add this linelocal_backend: true
npx netlify-cms-proxy-server
and in another runyarn start
Documentation
webpack-merge
documentation