fix(widgetsFor): return widgets for variable type lists #7296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using a Variable Type list widget and a custom preview component, the
widgetsFor
helper would only return adata
list with each of the items in the list, not awidgets
list, e.g.The
widgets
list should also be supplied, particularly for nested Markdown widgets, so a fully formatted preview can be rendered:This extends support in
widgetsFor
to detect variable type list widgets and correctly construct thewidgets
return value.Fixes #2307 (specifically #2307 (comment) which explains it neatly).
Test plan
Using the test backend, add the following custom preview helper:
Before:
Only the
data
value is populated, so only the raw Markdown is available. Thewidgets
return value is empty.After:
In the preview pane, the Markdown widget is now able to be used to render the field.
Checklist
Please add a
x
inside each checkbox: