-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): allow to store the new entry in the draft after a pre save #7227
Merged
martinjagodic
merged 9 commits into
decaporg:main
from
jmfiaschi:fix/persist_entity_for_i18n
Aug 2, 2024
Merged
fix(i18n): allow to store the new entry in the draft after a pre save #7227
martinjagodic
merged 9 commits into
decaporg:main
from
jmfiaschi:fix/persist_entity_for_i18n
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if someone can review |
martinjagodic
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmfiaschi please fix the linter error
martinjagodic
approved these changes
Aug 2, 2024
martinjagodic
added a commit
that referenced
this pull request
Aug 5, 2024
…#7227) * fix(i18n): allow to store the new entry in the draft after a pre save * feat(persistEntry): test preSave that return data or entry map * fix(linter): expected property shorthand object-shorthand * fix: format backend spec, update caniuse-lite --------- Co-authored-by: Martin Jagodic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixex #4729 : Today it's not possible for example to translate empty fields with external APIs with the
preSave
because thepreSave
expect to return only adata
that not containi18n
values.With this kind of code, we should be able to update the i18n values :
The change has no regression.
PreSave
can return data/entry modifications.Test plan
Done
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)