fix(backend): allow a custom API root for backend #7214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a self-hosted Gitlab, the API request to get the default branch always call gitlab.com. This commit allow to pass a custom API root from the config to the API call. Fix decaporg#7168
|
@JbIPS could you add this new setting to docs also? the best way is to submit a PR here: https://github.com/decaporg/decap-website |
|
Actually, the |
martinjagodic
approved these changes
Jul 2, 2024
|
Hi @JbIPS. Thanks for the effort. |
|
Hi @dbtek! Did you add |
|
Hi @JbIPS. Yeah I found it by accident 😊. It seems working now. Thanks! |
martinjagodic
added a commit
that referenced
this pull request
Aug 5, 2024
In case of a self-hosted Gitlab, the API request to get the default branch always call gitlab.com. This commit allow to pass a custom API root from the config to the API call. Fix #7168 Co-authored-by: Martin Jagodic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a self-hosted Gitlab, the API request to get the default branch always call gitlab.com.
This commit allow to pass a custom API root from the config to the API call.
Fixes #7168