Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper image path, when using dynamic media_folder #5855

Closed
wants to merge 1 commit into from

Conversation

smashercosmo
Copy link
Contributor

@smashercosmo smashercosmo commented Sep 30, 2021

Summary

Set proper image path by replacing it with the most actual media_folder field value. Fixes #3723

Test plan

No idea, how it should be tested.

Checklist

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

P.S

I'm not sure at all that this is a proper way to fix it. But decided to make a PR just to get discussion started.

@smashercosmo smashercosmo requested a review from a team September 30, 2021 13:04
@erezrokah erezrokah added the type: bug code to address defects in shipped code label Sep 30, 2021
@smashercosmo
Copy link
Contributor Author

Just tested this locally and seems that this doesn't fix the issue :(

@smashercosmo
Copy link
Contributor Author

Ok, I have to admit, that I'm stuck. Send help :)

@erezrokah
Copy link
Contributor

Thanks @smashercosmo, I'll try to have a look later this week

@erezrokah
Copy link
Contributor

Closing this PR to continue the discussion in the issue #3723

@erezrokah erezrokah closed this Oct 11, 2021
@smashercosmo smashercosmo deleted the proper-image-path branch October 11, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with using dynamic media_folder name
2 participants