Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributing guide: Add more details to Debugging section #5814

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

bytrangle
Copy link
Collaborator

Summary
I hope to make the Debugging section of the Contributing guide clearer to newbie contributors. Here is what I add:

  • Add more concrete instruction for configuring backend
  • Explain what users should look for when changing dev-test/index.html
  • Add more info to use local storage to set Netlify site's URL

Test plan

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)

- Add more concrete instruction for configuring backend
- Explain what users should look for when changing `dev-test/index.html`
- Add more info to use local storage to set Netlify site's URL
@bytrangle bytrangle requested a review from a team September 15, 2021 13:18
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 29, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bytrangle! Sorry for the late reply, I was out of office.
I'm back now (!) and will be going through issues and the rest of the PRs

@erezrokah erezrokah merged commit b611636 into decaporg:master Sep 29, 2021
@bytrangle
Copy link
Collaborator Author

Thank you @erezrokah . Please don't say sorry. You've always done a splendid job tidying up the PR section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants