closes #5548 add logo url to header #5558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: feature
|
Thanks @Nrestrepo05, this logo seems a bit too big in my opinion: I'll reduce the height a bit |
erezrokah
suggested changes
Jul 5, 2021
There was a problem hiding this comment.
Hi @Nrestrepo05, after going the PR again, it seems we should display the logo as a part of the SettingsDropdown left to the display URL:
https://github.com/netlify/netlify-cms/blob/18724ff991c4b8b16de1df40511dad368578a4b2/packages/netlify-cms-core/src/components/UI/SettingsDropdown.js#L74
That way it will also be present inside the editor. WDYT?
I'm aware
SettingsDropdowndoesn't reflect the exact functionality described by the name of that component
|
Closing this as stale. Please comment if you'd like to pick this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add logo to the header as asked here: #5548
A picture of a cute animal (not mandatory but encouraged)
