Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): incorrect import in index.d.ts #4962

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

smashercosmo
Copy link
Contributor

Summary

Constants were imported from the incorrect path

Test plan

No testing needed

@smashercosmo smashercosmo requested a review from a team February 16, 2021 15:53
@erezrokah erezrokah added the type: bug code to address defects in shipped code label Feb 16, 2021
@smashercosmo
Copy link
Contributor Author

Patch release needed. Because it breaks typescript projects with skipLibCheck: false

@erezrokah
Copy link
Contributor

Patch release needed. Because it breaks typescript projects with skipLibCheck: false

Sure. I'll merge and release once the tests pass

@smashercosmo
Copy link
Contributor Author

Hmm... I have a feeling, that in order this to work properly collectionTypes should be converted to TypeScript

@smashercosmo
Copy link
Contributor Author

smashercosmo commented Feb 16, 2021

Locally I get this errors from TS even with collectionTypes converted to TS

TS2439: Import or export declaration in an ambient module declaration cannot reference module through relative module name.
TS2307: Cannot find module './src/constants/collectionTypes' or its corresponding type declarations.

@smashercosmo
Copy link
Contributor Author

smashercosmo commented Feb 16, 2021

Seems like this works, but collectionTypes should be converted to TS
import { FILES, FOLDER } from 'netlify-cms-core/src/constants/collectionTypes';

@smashercosmo
Copy link
Contributor Author

I'll update the PR

@erezrokah erezrokah merged commit 10cb14f into decaporg:master Feb 16, 2021
@erezrokah
Copy link
Contributor

Released in [email protected]

@smashercosmo
Copy link
Contributor Author

Alright, can confirm, this fixed the issue 🎉

@erezrokah
Copy link
Contributor

Thank you for being on top of this 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants