refactor: remove immutable from 'config' state slice #4776
Conversation
|
Alright. Have to admit, this was a bit harder than previous refactorings and unfortunately required a lot of changes to be made in different places. It's 99% done, but still requires some polishing and thorough review. But at least all unit test are passing and TypeScript is mostly happy, except for some tricky places, which I still don't know how to handle properly (I'll mention all of them in comments). |
smashercosmo
force-pushed
the
remove-immutable-from-config
branch
9 times, most recently
from
7c9bcd6
to
f35ee6f
Compare
smashercosmo
force-pushed
the
remove-immutable-from-config
branch
2 times, most recently
from
bcbf658
to
01651ab
Compare
smashercosmo
force-pushed
the
remove-immutable-from-config
branch
from
01651ab
to
afa5d71
Compare
| @@ -655,9 +655,12 @@ const evaluateFolder = ( | |||
| collection.get(folderKey)!, | |||
| entryMap, | |||
| collection, | |||
| // TODO can't figure out how to handle this | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-ignore | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
According to config type media_folder can be undefined
| @@ -700,9 +703,12 @@ const evaluateFolder = ( | |||
| collection.get(folderKey)!, | |||
| entryMap, | |||
| collection, | |||
| // TODO can't figure out how to handle this | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-ignore | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
According to config type media_folder can be undefined
| if (camel in field) { | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-ignore | ||
| // @ts-ignore seems like it's impossible to make TS happy in this case | ||
| field[snake] = field[camel]; |
There was a problem hiding this comment.
I couldn't come up with proper typing :(
erezrokah
added
the
type: chore
|
There is no need to check this PR right now. I'm gonna send several more atomic PRs to make merging this one easier. |
Summary
Continue with #3853
Test plan
Run existing tests