-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Docs: Guides “gridsome” #4433
Create Docs: Guides “gridsome” #4433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milos5593 Thank you for creating this guide. Sorry for my late response.
Added a few comments - most of them are minor.
The main issue is to have this guide aligned with other guides with regards to pushing content to GitHub and connecting to Netlify (git-gateway and Identity).
website/content/docs/gridsome.md
Outdated
npm add netlify-cms gridsome-plugin-netlify-cms @gridsome/source-filesystem @gridsome/transformer-remark | ||
``` | ||
|
||
Now that the plugins are installed, it's now time to setup the right configuration. Open the `gridsome.config.js` file and make sure it looks like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the plugins are installed, it's now time to setup the right configuration. Open the `gridsome.config.js` file and make sure it looks like this: | |
Now that the plugins are installed, it's time to setup the configuration. Open the `gridsome.config.js` file and update its content to: |
website/content/docs/gridsome.md
Outdated
plugins: [ | ||
// ...global plugins | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins: [ | |
// ...global plugins | |
] |
website/content/docs/gridsome.md
Outdated
remark: { | ||
plugins: [ | ||
// ...local plugins | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remark: { | |
plugins: [ | |
// ...local plugins | |
] | |
} |
website/content/docs/gridsome.md
Outdated
} | ||
``` | ||
|
||
Please read [gridsome-plugin-netlify-cms](https://gridsome.org/plugins/gridsome-plugin-netlify-cms), [transformer-remark](https://gridsome.org/plugins/@gridsome/transformer-remark) for more information about the configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read [gridsome-plugin-netlify-cms](https://gridsome.org/plugins/gridsome-plugin-netlify-cms), [transformer-remark](https://gridsome.org/plugins/@gridsome/transformer-remark) for more information about the configurations. | |
Please read [gridsome-plugin-netlify-cms](https://gridsome.org/plugins/gridsome-plugin-netlify-cms), [transformer-remark](https://gridsome.org/plugins/@gridsome/transformer-remark) for more information. |
website/content/docs/gridsome.md
Outdated
<!doctype html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Netlify CMS</title> | ||
</head> | ||
<body> | ||
<script src="index.js" type="module"></script> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!doctype html> | |
<html> | |
<head> | |
<meta charset="utf-8"> | |
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | |
<title>Netlify CMS</title> | |
</head> | |
<body> | |
<script src="index.js" type="module"></script> | |
</body> | |
</html> | |
<!DOCTYPE html> | |
<html> | |
<head> | |
<meta charset="utf-8" /> | |
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |
<title>Netlify CMS</title> | |
</head> | |
<body> | |
<script src="index.js" type="module"></script> | |
</body> | |
</html> | |
website/content/docs/gridsome.md
Outdated
|
||
```yml | ||
backend: | ||
name: github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use git-gateway
like the other guides for consistency?
@erezrokah no problems, I'll make the changes in a couple of day's, need to finalize a project for a client. |
Sure no rush :) |
3134920
to
3162a46
Compare
@erezrokah Let me know if this works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milos5593, I added another commit to fix some syntax highlighting issues and replaced GitHub authentication with Identity
and git-gateway
as the config.yml
uses backend: git-gateway
.
The latter also aligns this guide with the other ones in regards with authentication method.
No description provided.