Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Docs: Guides “gridsome” #4433

Conversation

milos5593
Copy link
Contributor

No description provided.

@milos5593 milos5593 requested a review from a team October 10, 2020 00:13
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milos5593 Thank you for creating this guide. Sorry for my late response.
Added a few comments - most of them are minor.
The main issue is to have this guide aligned with other guides with regards to pushing content to GitHub and connecting to Netlify (git-gateway and Identity).

npm add netlify-cms gridsome-plugin-netlify-cms @gridsome/source-filesystem @gridsome/transformer-remark
```

Now that the plugins are installed, it's now time to setup the right configuration. Open the `gridsome.config.js` file and make sure it looks like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now that the plugins are installed, it's now time to setup the right configuration. Open the `gridsome.config.js` file and make sure it looks like this:
Now that the plugins are installed, it's time to setup the configuration. Open the `gridsome.config.js` file and update its content to:

Comment on lines 54 to 56
plugins: [
// ...global plugins
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plugins: [
// ...global plugins
]

Comment on lines 66 to 70
remark: {
plugins: [
// ...local plugins
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
remark: {
plugins: [
// ...local plugins
]
}

}
```

Please read [gridsome-plugin-netlify-cms](https://gridsome.org/plugins/gridsome-plugin-netlify-cms), [transformer-remark](https://gridsome.org/plugins/@gridsome/transformer-remark) for more information about the configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please read [gridsome-plugin-netlify-cms](https://gridsome.org/plugins/gridsome-plugin-netlify-cms), [transformer-remark](https://gridsome.org/plugins/@gridsome/transformer-remark) for more information about the configurations.
Please read [gridsome-plugin-netlify-cms](https://gridsome.org/plugins/gridsome-plugin-netlify-cms), [transformer-remark](https://gridsome.org/plugins/@gridsome/transformer-remark) for more information.

Comment on lines 94 to 96
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Netlify CMS</title>
</head>
<body>
<script src="index.js" type="module"></script>
</body>
</html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Netlify CMS</title>
</head>
<body>
<script src="index.js" type="module"></script>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Netlify CMS</title>
</head>
<body>
<script src="index.js" type="module"></script>
</body>
</html>


```yml
backend:
name: github
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use git-gateway like the other guides for consistency?

website/content/docs/gridsome.md Outdated Show resolved Hide resolved
@milos5593
Copy link
Contributor Author

milos5593 commented Oct 25, 2020

@erezrokah no problems, I'll make the changes in a couple of day's, need to finalize a project for a client.

@erezrokah
Copy link
Contributor

I'll make the changes in a couple of day's, need to finalize a project for a client.

Sure no rush :)

@milos5593 milos5593 force-pushed the cms/milos5593/netlify-cms/docs_guides/gridsome branch from 3134920 to 3162a46 Compare October 31, 2020 22:59
@milos5593
Copy link
Contributor Author

@erezrokah Let me know if this works.

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @milos5593, I added another commit to fix some syntax highlighting issues and replaced GitHub authentication with Identity and git-gateway as the config.yml uses backend: git-gateway.
The latter also aligns this guide with the other ones in regards with authentication method.

@erezrokah erezrokah merged commit 922c1a7 into decaporg:master Nov 2, 2020
vladdu pushed a commit to vladdu/netlify-cms that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants