fix!: ignore metadata when setting entry unsaved flag #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relation widget updates metadata when first loading the relationship mapping. These metadata updates cause any collections using the relation widget to always get marked as having usaved changes whenever they are opened. Note: This is obviously a pretty serious change to the underlying data model semantics. It might not make sense, but there didn't seem to be a better way of handling the relation widget without adding an extra field to the DRAFT_CHANGE_FIELD action to flag that this is a metadata only change and to leave the `hasChanged` field alone.
|
@bharrisau, thanks for this. Will go over soon along with #3306 to figure out which one covers more use cases. |
|
Wow, two independent fixes for the same thing with sequential IDs.
…On Wed, 26 Feb 2020, 2:53 am Erez Rokah, ***@***.***> wrote:
@bharrisau <https://github.com/bharrisau>, thanks for this. Will go over
soon along with #3306 <#3306>
to figure which one covers more use cases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3305>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5JFTO5DYDGRGJQ6G346DREVSI3ANCNFSM4KZXKWBA>
.
|
|
@bharrisau I'm closing this in favour of #3306 as that one seems to cover a wider range of issues (see the issue linked there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relation widget updates metadata when first loading the relationship mapping.
These metadata updates cause any collections using the relation widget to always
get marked as having usaved changes whenever they are opened.
Note: This is obviously a pretty serious change to the underlying data model
semantics. It might not make sense, but there didn't seem to be a better way of handling
the relation widget without adding an extra field to the DRAFT_CHANGE_FIELD action
to flag that this is a metadata only change and to leave the
hasChangedfield alone.This is the 'metadata fix' from #2377. Some of the issues reported in #725 will be resolved (#725 is only for new entries and default values, but many of the relation widget complaints for existing entries are being funneled to that issue - see #2743)
fixes #2211
Test plan
I've testing this fixed the relation widget for myself. I wasn't able to run the e2e test package on this machine when trying the
tests:allscript. The new test spec sets thehasChangedsemantic.A picture of a cute animal (not mandatory but encouraged)