[WIP] Validate nested fields #1675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit 271870c |
erquhart
commented
Aug 25, 2018
| hasChanged: false, | ||
| }); | ||
|
|
||
| const entryDraftReducer = (state = Map(), action) => { | ||
| const entryDraftReducer = (state = initialState, action) => { |
There was a problem hiding this comment.
I don't know why we weren't doing this already, but if it causes bugs, we should just fix them. intialState becomes the default from the first time you open the editor, even if you go to other screens after, so we should just use it from the start.
|
Too many issues with this approach 🙄, will try a different tack in a separate PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Finally validate nested fields.
Functionality here is working, but we need to hunt down and address edge cases before merging. This also surfaces UI oddities that should be addressed as well.
Note that this will feel like a breaking change for a whole lot of folks, but it's technically a bug fix. Open to discussion on how best to release, but I expect we'll drop it in a feature release and apologize on Twitter. If backlash is overwhelming we can maybe add an option to disable until 3.0, but hoping we can avoid that.
Closes #467.
Dev notes, issues
This fix takes advantage of the
EditorControlcomponent, which wraps every widget, being connected directly to the Redux store as of 2.0. We're storing validation functions in Redux when each widget mounts, and removing them on unmount.(Update: working on an alternate approach to keep state serializable.)