Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-repo crash on non-existent folder. #1444

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Jun 15, 2018

- Summary

The test-repo backend was crashing if a different folder was specified in the config. Fixes #1438.

- Test plan
Manually tested.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@tech4him1
Copy link
Contributor Author

This will need backported to v1 as well.

@verythorough
Copy link
Contributor

Deploy preview for cms-demo ready!

Built with commit 3c8cbc6

https://deploy-preview-1444--cms-demo.netlify.com

@verythorough
Copy link
Contributor

Deploy preview for netlify-cms-www ready!

Built with commit 3c8cbc6

https://deploy-preview-1444--netlify-cms-www.netlify.com

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@erquhart erquhart merged commit 427ba7d into decaporg:master Jun 15, 2018
@tech4him1 tech4him1 deleted the 1438-test-repo-crash branch June 15, 2018 21:46
@tech4him1
Copy link
Contributor Author

tech4him1 commented Jun 15, 2018

@erquhart Can you pull this into the v1 branch as well?

erquhart pushed a commit to erquhart/netlify-cms that referenced this pull request Jun 16, 2018
@erquhart
Copy link
Contributor

@tech4him1 done, released in 1.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After login: TypeError: Cannot convert undefined or null to object
3 participants