Only use label_singular when one item is rendered in the listControl #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes decaporg#1397. Check the size of the item list and set the listlabel based on that. If no label_singular is set, fall back to the normal label
|
Deploy preview for netlify-cms-www ready! Built with commit aea97b2 |
|
Deploy preview for cms-demo ready! Built with commit aea97b2 |
erquhart
pushed a commit
to erquhart/netlify-cms
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1397.
Check the size of the item list and set the listLabel based on that.
If no label_singular is set, fall back to the normal label
- Summary
The list control always used the singular name as label if one is specified, even when the list contains 0 or > 1 items. It's now based on the amount of items thats provided.
- Test plan
Tested with the existing authors settings in the example CMS.
With 2 authors:
With 1 author:
With 0 authors:
- Description for the changelog
Base the listLabel on the size of the list provided.
- A picture of a cute animal (not mandatory but encouraged)
