fix workflow top panel styling #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cms-demo ready! Built with commit 47af2ef |
|
Deploy preview for netlify-cms-www ready! Built with commit 47af2ef |
tech4him1
reviewed
Jun 1, 2018
src/components/Workflow/Workflow.css
Outdated
| @@ -2,8 +2,7 @@ | |||
| @import "./WorkflowCard.css"; | |||
|
|
|||
| .nc-workflow { | |||
| padding: var(--pageMargin); | |||
| padding-bottom: 0; | |||
| padding: var(--pageMarginVertical) var(--pageMarginHorizontal) 0; | |||
There was a problem hiding this comment.
@erquhart We could just do padding: var(--pageMargin) 0;, instead of splitting it into vertical and horizontal. I'm fine either way.
There was a problem hiding this comment.
Duh, totally forgot about the three value syntax, good point.
tech4him1
approved these changes
Jun 1, 2018
erquhart
force-pushed
the
fix-workflow-top
branch
from
65f846f
to
47af2ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes styling break from recent dependencies update. Native CSS variables combined with PostCSS output optimizations converted this:
to this:
PostCSS static analysis counted the vars as single values, but the variable equates to
84px 18px, leading to an output of84px 18px 84px 18px 0, which fails in the browser.Fixed by not declaring the bottom padding subsequent to general padding declaration, but we should consider changing or dropping related optimizations if these kinds of issues prove common.
Bug demo: https://5b084974c965920b4c7644e3--cms-demo.netlify.com/#/workflow
Fix demo: https://deploy-preview-1398--cms-demo.netlify.com/#/workflow