Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Media library thumbnails #1230

Closed

Conversation

owenhoskins
Copy link

WIP for #946

  • Implementation of pica.toCanvas to generate thumbnails on the fly in MediaLibrary/CardImage.js
  • Using react-intersection-observer in EditorWidgets/GalleryPreview to throttle the toCanvas calls
  • Using react-virtualized in the MediaLibrary to handle large sets of data and also throttle toCanvas calls

@verythorough
Copy link
Contributor

verythorough commented Apr 5, 2018

Deploy preview for netlify-cms-www ready!

Built with commit 56b9856

https://deploy-preview-1230--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

verythorough commented Apr 5, 2018

Deploy preview for cms-demo ready!

Built with commit 56b9856

https://deploy-preview-1230--cms-demo.netlify.com

@ro-savage
Copy link

@owenhoskins - Will this allow users to upload and previews images without them being directly uploaded to github master branch?

@erquhart
Copy link
Contributor

erquhart commented May 8, 2018

No, just performance improvements for the media library interface.

Sent with GitHawk

@mbergeronupgrade
Copy link

Waiting for this mostly to fix #787

@tech4him1
Copy link
Contributor

tech4him1 commented Jun 5, 2018

@owenhoskins Let me know if you want any help on this! I'd be glad to work on the backend integration (saving thumbnails) part if you're ready for that.

@owenhoskins
Copy link
Author

@tech4him1 So glad you asked, that'd be awesome! I can hit you up on Gitter tomorrow or sometime this week? I finally got clear of a few things so this is coming back in focus!

@erquhart
Copy link
Contributor

@owenhoskins going to go ahead and close this as stale, but please comment to re-open if you dig any further on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants