Fix broken new media uploads in Git Gateway. #1221
Conversation
|
Deploy preview for cms-demo ready! Built with commit e806679 |
|
Deploy preview for netlify-cms-www ready! Built with commit e806679 |
| const isPrivateRepo = await this.api.isPrivateRepo(); | ||
| if (isPrivateRepo) { | ||
| if (!this.isPrivateRepo) { | ||
| this.isPrivateRepo = await this.api.checkPrivateRepo(`${this.api_root}/repos/${repo}`); |
There was a problem hiding this comment.
The value is cached here since GitHub limits unauthenticated API requests. The only downside is that you need to reload the CMS page if you change the repo from public to private.
There was a problem hiding this comment.
I think that's a fine compromise.
src/backends/git-gateway/API.js
Outdated
| checkPrivateRepo(url) { | ||
| const cacheBuster = new Date().getTime(); | ||
| return fetch(`${url}?ts=${cacheBuster}`) | ||
| .then(response => response.ok); |
There was a problem hiding this comment.
It might be a good idea to check if we get a 403 (rate limited) error here, and assume that the repo is private in that case so that thumbnails don't break.
tech4him1
changed the title
| @@ -139,8 +139,10 @@ export default class GitHub { | |||
| let url = `https://raw.githubusercontent.com/${repo}/${this.branch}${path}`; | |||
|
|
|||
| // Assets uploaded to private repos will need valid access tokens. | |||
| const isPrivateRepo = await this.api.isPrivateRepo(); | |||
| if (isPrivateRepo) { | |||
| if (!this.isPrivateRepo) { | |||
There was a problem hiding this comment.
This condition would result in an unauthenticated check on every persist for public repos, maybe we should check for the presence of a Boolean instead.
|
@erquhart Great, thank you. |
|
As bad of a solution as it is, it may be better to always treat Git Gateway repos as private until #990 is in place. |
|
I've updated the PR to use the file contents directly (as a It works perfectly for me using GitHub and Git-Gateway backends with a public repo. @erquhart Can you test on a private repo? |
* Use file data instead of inferring path for new uploads.
- Summary
New media uploads do not appear at all until the CMS is reloaded (not the thumbnail or filename) when using the Git Gateway backend after #994. This PR resolves #1220.
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)