update website release ticker via cms #1144
Conversation
|
Deploy preview for netlify-cms-www ready! Built with commit ab6c8a3 |
|
Deploy preview for cms-demo ready! Built with commit ab6c8a3 |
| @@ -36,7 +36,7 @@ <h3>{{ .feature | markdownify }}</h3> | |||
| <ol> | |||
| {{ range .Site.Data.updates }} | |||
| {{ range first 3 . }} | |||
| <a href="{{ .url }}"><li><div class="update-metadata"><span class="update-version">{{ .version }}</span><span class="update-date">{{ dateFormat "January 2, 2006" .date }}</span></div><span class="update-description">{{ .description | markdownify }}</span></li></a> | |||
There was a problem hiding this comment.
Why not just use the url from the updates.yml?
There was a problem hiding this comment.
That's what this is - Site.Data.updates is read in from the yaml.
There was a problem hiding this comment.
It was changed from {{ .url }} to https://github.com/netlify/netlify-cms/releases/tag/{{ .version }}. We still have the URL in the Site.Data.updates, though, why not just use that url?
There was a problem hiding this comment.
Oh, sorry, should have looked closer.
We're going to drop the urls entirely - that way we don't have to manually enter a url every time, just derive it using the version. Not sure why I didn't drop them.
erquhart
force-pushed
the
website-releases-cms-config
branch
from
d785aaa
to
ab6c8a3
Compare
|
Agreed. |
|
Merge after #1143, otherwise date formats will be wrong. |
No description provided.