Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax pyparsing version specifier #840

Closed
wants to merge 1 commit into from

Conversation

ninoseki
Copy link
Contributor

Relax pyparsing version specifier to allow using pyparsing v3.

Background

I want to use oletools with a library which specifically requires pyparsing v3+. More specifically, this one.

v2-v3 Compatibility

v3 starts using snake_case API (e.g. add_parse_action) but it preserves camelCase API. So, as far as I checked, it's safe to use v3 with the current usage. (Ref. https://pyparsing-docs.readthedocs.io/en/latest/whats_new_in_3_0_0.html#api-changes)

@ninoseki
Copy link
Contributor Author

ninoseki commented Mar 3, 2024

I'm sorry. I realized this PR is duplicated with #812. So let me close this PR.

@ninoseki ninoseki closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants