Oleobj preserve file extension #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-intra2net
force-pushed
the
oleobj-preserve-suffix
branch
from
08d87ed
to
a4c831f
Compare
|
Rebased onto current master |
christian-intra2net
force-pushed
the
oleobj-preserve-suffix
branch
2 times, most recently
from
446aa9b
to
9334846
Compare
christian-intra2net
force-pushed
the
oleobj-preserve-suffix
branch
from
9334846
to
b1f2811
Compare
|
Rebased to keep up-to-date. |
christian-intra2net
force-pushed
the
oleobj-preserve-suffix
branch
from
b1f2811
to
b2006c6
Compare
|
Rebased onto current master |
Sofar we have only looked at the `filename` attribute but in malware samples the path has been empty and windows used src_path or tmp_path to determine dumped file type. Look at all 3 filenames/paths, try to preserve suffix but still limit length of resulting file name. Deal with multiple objects of same resulting filename by offering random file names
christian-intra2net
force-pushed
the
oleobj-preserve-suffix
branch
from
b2006c6
to
eb0b509
Compare
|
Rebased onto current master. Added the unittest fix commit from #761 so I can run branch unittests |
decalage2
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered malware samples where "Filename" of an embedded file was " " (just a space), but "Source Path" and "Temp Path" contained a proper filename. Seems to be enough for windows to recognize the file type. So extract file name (in particular: the file extension) from paths if "Filename" is not helpful.
Realized that lots of things can go wrong creating filenames: collisions with other files, extremely long names, different path separators ("/" vs ""). Address these issues, too.