Fix TypeError in VBA_Parser.analyze_macros() (can't concat bytes to s… #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK thanks, I need to check that more in details. In the new version 0.54, we should return str depending on the Python version: bytes on Py2, unicode on Py3. The problem is, the codec should not be UTF-8, but based on the code page of the VBA project. Which we don't have in this case... |
|
OK, I'm aware that this is just a hotfix for my needs (Py3). Hope this will be fixed properly in the next version :) |
|
I might use chardet in this case when we don't have the code page: https://github.com/chardet/chardet |
enkelli
force-pushed
the
fix-olevba-type-error-concat-bytes-to-str
branch
from
79cddcd
to
2a92116
Compare
…tr). Similar to PR decalage2#288. `decompress_stream()` yields bytes but vba_code value returned from `extract_macros()` should be AFAIK string in Python 3.
enkelli
force-pushed
the
fix-olevba-type-error-concat-bytes-to-str
branch
from
2a92116
to
3e9d763
Compare
I've changed the PR implementation to use chardet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tr).
Similar to PR #288.
decompress_stream()yields bytes butvba_codevalue returned fromextract_macros()should be AFAIK string (at least all otheryields returnstring.
Sample that failed: 871beebb71290d040584fa7587c608b50e0d42e0f7657e10946de640ee4c3f1b