Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for EOL suites with expired GPG keys #60

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

tianon
Copy link
Collaborator

@tianon tianon commented Apr 14, 2019

For the sake of EOL releases (whose archive keys have often expired), we need a fake gpgv substitute that will essentially ignore just key expiration.

(So we get some signature validation instead of using something like --allow-unauthenticated or --force-yes which disable security entirely instead.)

This workaround only gets applied when we're doing an EOL build, and only when the APT version is new enough to need it (older APT versions didn't verify that).

This is the last bits needed in debuerreotype itself to finally take care of debuerreotype/docker-debian-artifacts#65. With this, I have successfully verified the full reproducibility of woody/3.0 through wheezy/7.0 across two days across i386, arm, armel, armhf, and amd64 as applicable.

For the sake of EOL releases (whose archive keys have often expired), we need a fake `gpgv` substitute that will essentially ignore *just* key expiration.

(So we get *some* signature validation instead of using something like `--allow-unauthenticated` or `--force-yes` which disable security entirely instead.)

This workaround *only* gets applied when we're doing an EOL build, and only when the APT version is new enough to need it (older APT versions didn't verify that).
@tianon
Copy link
Collaborator Author

tianon commented Apr 14, 2019

I've also tested this against potato, although I haven't verified the full reproducibility of potato against this thanks to moby/moby#5364 (the machine I was doing most of my testing on unluckily hits that error).

@tianon tianon merged commit 799473b into debuerreotype:master Apr 15, 2019
@tianon tianon deleted the eol-gpgv-ignore-expiration branch April 15, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant