Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of Slider Component #72

Merged
merged 11 commits into from
Jul 14, 2016

Conversation

vipentti
Copy link
Collaborator

@vipentti vipentti commented Jul 7, 2016

Initial implementation of a Slider component to resolve #69.

Did a major refactor of the API based on the discussion.

The component does not currently use or support Parts component model because the component itself has no need for update because of the user having to provide both onChange and value calls to update the slider.

Slider does not currently work properly on Microsoft Edge. It also does not currently look the best on regular Internet Explorer due to flexbox. However, it is functional.

Example use:

import Material.Slider as Slider

slider : Model -> Html Msg
slider model =
    p [ style [ ("width", "300px") ] ]
    [ Slider.slider
        [ Slider.onChange SliderMsg
        , Slider.value model.value
        ]
    ]

This follows the MDL of wrapping the actual slider in a separate element that has a width specified.

@debois debois merged commit 16eeb8e into debois:master Jul 14, 2016
@debois
Copy link
Owner

debois commented Jul 14, 2016

Very good—I merged this, leaving open issues #75 and #76 about IE/Edge compatibility.

@vipentti vipentti deleted the slider-component branch September 1, 2016 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants