Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update EMR to PHR #529

Merged
merged 6 commits into from
Jul 29, 2022
Merged

refactor: update EMR to PHR #529

merged 6 commits into from
Jul 29, 2022

Conversation

bukandicki
Copy link
Contributor

@bukandicki bukandicki commented Jul 21, 2022 •
edited
Loading

JIRA LINK 🟦

Changelog/Description 🗒️

  • Refactor EMR naming convention to PHR include (File, Route, Folder, and Test Unit)
  • Add file information

WARNING ⚠️

Screenshoot/Video (Optional) 🖼️

@bukandicki bukandicki added the refactor Code refactor, and other code related changes that doesn't include business flow. label Jul 21, 2022
@bukandicki bukandicki self-assigned this Jul 21, 2022
@agustinustheo agustinustheo removed their request for review July 21, 2022 15:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bukandicki bukandicki requested a review from hilyds July 27, 2022 03:37
ciniiia
ciniiia approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ciniiia ciniiia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hilyds hilyds merged commit 6d3a6bc into debionetwork:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciniiia ciniiia ciniiia approved these changes

@hilyds hilyds hilyds approved these changes

@azmimuhammad azmimuhammad Awaiting requested review from azmimuhammad

Assignees

@bukandicki bukandicki

Labels
refactor Code refactor, and other code related changes that doesn't include business flow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bukandicki @hilyds @ciniiia