Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Enhance request test #451

Merged
merged 4 commits into from
May 30, 2022
Merged

fix : Enhance request test #451

merged 4 commits into from
May 30, 2022

Conversation

ciniiia
Copy link
Contributor

@ciniiia ciniiia commented May 23, 2022

JIRA LINK 🟦

Changelog/Description 🗒️

  • refactor cards on request test flow
  • adjust unit test
  • fix bugs
  • add validation on payment receipt dialog

WARNING ⚠️

Screenshoot/Video (Optional) 🖼️

@ciniiia ciniiia requested review from agustinustheo, bukandicki, hilyds and azmimuhammad and removed request for agustinustheo May 23, 2022 18:21
@ciniiia ciniiia self-assigned this May 23, 2022
@ciniiia ciniiia added fix Bug fixing something that isn't working test Create or edit tests for features. labels May 23, 2022
@hilyds hilyds changed the title Enhance request test fix : Enhance request test May 30, 2022
hilyds
hilyds approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@hilyds hilyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hilyds hilyds added the refactor Code refactor, and other code related changes that doesn't include business flow. label May 30, 2022
@hilyds hilyds merged commit 9b9661f into debionetwork:main May 30, 2022
@ciniiia ciniiia deleted the enhance-request-test branch June 28, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilyds hilyds hilyds approved these changes

@bukandicki bukandicki Awaiting requested review from bukandicki

@agustinustheo agustinustheo Awaiting requested review from agustinustheo

@azmimuhammad azmimuhammad Awaiting requested review from azmimuhammad

Assignees

@ciniiia ciniiia

Labels
fix Bug fixing something that isn't working refactor Code refactor, and other code related changes that doesn't include business flow. test Create or edit tests for features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciniiia @hilyds