Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7972 Debezium UI Update blogpost #1050

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

jcechace
Copy link
Member

@jcechace jcechace commented Aug 6, 2024

@jcechace jcechace requested a review from jpechane August 6, 2024 08:03
Copy link

github-actions bot commented Aug 6, 2024

🎊 PR Preview has been successfully built and deployed to https://debezium-debezium-github-io-preview-pr-1050.surge.sh

Copy link
Member

@vjuranek vjuranek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Spotted as few typos.

_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jpechane jpechane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcechace The contents LGTM, thanks a lot!

@roldanbob Could you please take a look at it from stylistic/grammar PoV?

_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Show resolved Hide resolved
@jcechace
Copy link
Member Author

jcechace commented Aug 6, 2024

@jpechane the broken images seem to be a problem in the preview. Locally they are displayed just fine.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @jcechace. I made a few quick copy edits to fix typos, spelling, etc.

_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
_posts/2024-08-05-Debezium-ui-update.adoc Outdated Show resolved Hide resolved
Co-authored-by: roldanbob <broldan@redhat.com>
@jcechace
Copy link
Member Author

jcechace commented Aug 6, 2024

Thanks a lot @roldanbob

@Naros @jpechane feel free to merge please

@roldanbob
Copy link
Contributor

Thanks a lot @roldanbob

My pleasure!

@roldanbob roldanbob self-requested a review August 6, 2024 20:54
@jcechace jcechace merged commit e574bde into debezium:develop Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants