Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More binder #1

Merged
merged 12 commits into from
Mar 3, 2021
Merged

More binder #1

merged 12 commits into from
Mar 3, 2021

Conversation

bollwyvl
Copy link

@bollwyvl bollwyvl commented Mar 3, 2021

https://gke2.mybinder.org/v2/gh/bollwyvl/accessibility/more-binder?urlpath=lab

  • moves the repo specification to another yaml file
    • can't tell, but don't think the commits were checking out properly
  • reworks entropy with a custom .yarn-links folder that doesn't break my local stuff 😊
  • clobbers the main $PREFIX/share/jupyter/lab with stuff from ./jupyterlab/dev_mode
    • gives a shorter binder url... and means binder's "stock" federated extensions will load (e.g. widgets, offlineonotebook)
    • obviates need for custom start
  • runs black

Trying to merge the current upstream HEAD was a bridge too far, and didn't work... but the machinery is there to do octopus-style merges, if they are all fast-forward. Behavior is somewhat undefined if the merges don't work.

As for validation, based on the two commits:

  • the checkable command palette items have aria-checked set
  • the sidebars don't say main sidebar navigation

So i think it's pulling stuff in, properly.

@tonyfast tonyfast merged commit 8b10083 into deathbeds:binder Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants