following #102, fix the Android part #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardojunio
added a commit
to eduardojunio/react-native-sortable-listview
that referenced
this pull request
Sep 14, 2017
following deanmcpherson#102, fix the Android part (deanmcpherson#105)
|
Great, thanks @nihgwu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix the item position issue described in #101 in #102, but I only test it on iOS, I'm so sorry for my carelessness.
I spend some time to investigate the remain issue on Android, I found that
measurealways returnundefinedinstead of a layout object as it does on iOS, and I found this facebook/react-native#12966, but addingcollapsable={false}is not enough, it works well on new RN versions, but in theSortableexample in this repo, all the returned layout fields are0, so I have to add asetTimeout(0)to fix it, although I don't like this idea, but sometimes we just need it.