컴포넌트 버튼 추가 가독성 및 사용성 개선 #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosh-deali
requested review from
ChangHoLee,
devgster,
dlskawns96 and
jalynneyoon
jalynneyoon
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
컴포넌트가 점점 많아지면서 테스트 시 버튼을 찾기가 어려워 타이틀 기준 정렬을 추가해보았습니다.
(PlayGround는 컴포넌트는 최상단 유지)
아래와 같이 버튼 객체를 직접 생성하지 않고 추가 가능하도록 개선하였습니다.
self.addComponents(title: "Accordion Components", actionSelector: #selector(accordionComponentsPressed))