Switch to ureq 2.0 #134
Merged
Switch to ureq 2.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-enhancement
jyn514
force-pushed
the
ureq-2
branch
2 times, most recently
from
07f6242
to
f934f83
Compare
|
Hmm, I think this is a real regression: fetching 308 URLs worked in 1.5.4, but not in 2.0. |
|
This is blocked on algesten/ureq#289 (for algesten/ureq#288). |
|
2.0.1 is released now, with the fixes you need! |
- Remove redundant url field. This can now be found from ureq itself. - Implement `From` now that the URL field is gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats to @jsha and @algestan on the release 🎉 The new code is shorter and even gets rid of a dependency :)
This is a breaking change since deadlinks has
ureq::Transportin the public API.