Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http checking #2

Closed
hobofan opened this issue Mar 25, 2016 · 2 comments
Closed

Add http checking #2

hobofan opened this issue Mar 25, 2016 · 2 comments
Labels
C-enhancement Category: This is a new feature
Milestone

Comments

@hobofan
Copy link
Member

hobofan commented Mar 25, 2016

Currently we are only checking file:// links but checking http links is obviously a high priority.

Some things to consider:

  • The results of http checks should probably be cached since it is very likely that the same link is used multiple times
  • I don't think that it should be the default since even with a handful of links it is bound to be slow and the result flaky depending on the network connection.
@hobofan
Copy link
Member Author

hobofan commented Oct 6, 2017

It might also might sense to have a "disallow-http" flag that disallows all links that are not on a whitelist, in order to ensure that the documentation completely works offline.

With #10 merged, this should be fairly straightforward, if we also pass a configuration struct through to all tests.

@hobofan hobofan added the C-enhancement Category: This is a new feature label Oct 13, 2017
@gsquire gsquire mentioned this issue Feb 18, 2018
3 tasks
@hobofan hobofan reopened this Feb 20, 2018
@hobofan
Copy link
Member Author

hobofan commented Feb 20, 2018

Implemented in #22, but one thing is still missing for it to be ready for a release:

I don't think that it should be the default since even with a handful of links it is bound to be slow and the result flaky depending on the network connection.

@hobofan hobofan added this to the 0.4.0 milestone Feb 20, 2018
hobofan added a commit that referenced this issue Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is a new feature
Projects
None yet
Development

No branches or pull requests

1 participant