Adding modify_source_note()
function
#2071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
modify_source_note()
andremove_source_note()
for adding and removing source notes. (Support for multiple source notes within gtsummary #1910)If there is an GitHub issue associated with this pull request, please provide link.
closes #1910
A few more details: Source notes have been a part of gtsummary for a long time, but there has never been a user-facing interface for adding them. In this PR, we add functions to add and remove source notes from a table. The way that source notes are saved has been updated to be more general (that is, so we can add more than a single source note). There may have been some advanced users who accessed the internals and added source notes, and if they had, this will be a breaking change.
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again