Meilisearch extra #316
Merged
Meilisearch extra #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## dev #316 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 47 +2
Lines 1794 1837 +43
=========================================
+ Hits 1794 1837 +43
Continue to review full report at Codecov.
|
|
I saw that extra md formatting with VSCode. You should be able to avoid it by disabling the format-on-save for markdown in the VSCode settings. This post should help. |
ddnexus
reviewed
Jun 19, 2021
|
Nice contribution! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed PR for Meilisearch extras as a replacement for #313
@ddnexus I took into account you comments about code style and fixed them. But with docs I have some difficulties with Vscode, which makes some extra changes to markdown layout (some extra spaces, asterisk replacements etc). I have no experience with markdown at all, thats why I dont include docs commit here.