Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra i18n namespacing #293

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

whithajess
Copy link
Contributor

@whithajess whithajess commented Apr 7, 2021

Fixes: #290

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #293 (d739c8b) into master (c178c6f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d739c8b differs from pull request most recent head 289ea67. Consider uploading reports for the commit 289ea67 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          537       537           
=========================================
  Hits           537       537           
Impacted Files Coverage Δ
lib/pagy/extras/i18n.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c178c6f...289ea67. Read the comment docs.

@ddnexus ddnexus changed the base branch from master to dev April 8, 2021 08:29
@ddnexus ddnexus merged commit 3a9e70f into ddnexus:dev Apr 8, 2021
@ddnexus
Copy link
Owner

ddnexus commented Apr 8, 2021

Thank you!

ddnexus added a commit that referenced this pull request Apr 8, 2021
ddnexus added a commit that referenced this pull request Apr 8, 2021
@whithajess whithajess deleted the 290/fix-extra-i18n-namespacing branch April 8, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I18n Extra no longer performs as expected in pagy >= 4.0.0
2 participants