Support ES5 on elasticsearch rails #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaHuang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 530 532 +2
=========================================
+ Hits 530 532 +2
Continue to review full report at Codecov.
|
|
Thank you! |
|
Thank you!! It's my honor. |
|
Hey, I've just realized that we missed something: What if raw_response is not defined?
|
ddnexus
added a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby: 2.5.7
Rails: 5.2.4.2
Elasticsearch: 5.6.16 and 6.8.8 (elasticsearch official docker image)
also attached tests
If anything has to improve, please let me know.