Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilePlayer.loop(numLoops) does not work properly #39

Closed
ddf opened this issue Aug 30, 2015 · 1 comment
Closed

FilePlayer.loop(numLoops) does not work properly #39

ddf opened this issue Aug 30, 2015 · 1 comment
Milestone
2.2.2

Comments

@ddf
Copy link
Owner

ddf commented Aug 30, 2015

Instead of stopping after the 0th loop, it will jump from loopCount 1 to loopCount -1, at which point it continues to loop indefinitely. This is related to the fact that FilePlayer uses read() on the AudioRecordingStream, rather than read(MultiChannelBuffer).
ddf added a commit that referenced this issue Sep 6, 2015
@ddf
Test case for Issue #39
23787cb
ddf added a commit that referenced this issue Sep 12, 2015
@ddf
Fixes Issue #39
d96d0dc 
- telling a FilePlayer to loop a fixed number of times would result in it jumping from a loop count of 1 to a loop count of -1, which meant it would loop indefinitely
@ddf ddf added this to the 2.2.2 milestone Sep 12, 2015
@ddf ddf closed this as completed Sep 12, 2015
@matinlotfali
Copy link

I want to open this issue again. #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@ddf @matinlotfali