Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused file for router, for #5266 #6581

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Oct 2, 2024

The Issue

Follow up for:

How This PR Solves The Issue

Removes router_Dockerfile_template file, that is not used anywhere.

Manual Testing Instructions

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner October 2, 2024 16:36
@stasadev stasadev changed the title fix: remove unused file for router, for # fix: remove unused file for router, for #5266 Oct 2, 2024
@github-actions github-actions bot added the bugfix label Oct 2, 2024
@rfay
Copy link
Member

rfay commented Oct 2, 2024

This got lost when we moved to a completely pre-built traefik router, instead of having it built at start. That approach got too many failures.

@rfay rfay merged commit 725b859 into ddev:master Oct 2, 2024
21 checks passed
@stasadev stasadev deleted the 20241002_stasadev_remove_unused_file branch October 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants