fix: Use port 80 to get better headers for Codespaces, fixes #6102 #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR.
|
stasadev
requested changes
Jul 15, 2024
rfay
commented
Jul 15, 2024
rfay
force-pushed
the
20240714_rfay_codespaces_http_port
branch
from
19b5095
to
d1391fb
Compare
|
Open to your suggestions, thanks for catching the copy/paste failure. |
stasadev
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Handling ports in HTTP is always a little complex, port 80 is default for http, port 443 for https. Codespaces seems to handle the Host header and X-Forwarded-Host incorrectly when it's forwarding a nonstandard (not port 80) port.
How This PR Solves The Issue
Use port 80 by default in codespaces. This seems to do no harm. It affects only Codespaces.
Manual Testing Instructions