Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump yq to v4.44.1 #6299

Merged
merged 3 commits into from
Jun 12, 2024
Merged

build: bump yq to v4.44.1 #6299

merged 3 commits into from
Jun 12, 2024

Conversation

juanjol
Copy link
Contributor

@juanjol juanjol commented Jun 11, 2024

The Issue

yq yaml parser has a new version with multiple improvements

How This PR Solves The Issue

bump version to the latests stable release (v4.44.1)

Manual Testing Instructions

install ddev with this PR and launch yq --version inside web container. Version should be v4.44.1.

Automated Testing Overview

None

Release/Deployment Notes

None

@juanjol juanjol requested a review from a team as a code owner June 11, 2024 17:09
@rfay
Copy link
Member

rfay commented Jun 11, 2024

Just changing it here doesn't make it actually change. A new image has to be pushed and be referred to in the versionconstants.go.

Can you say why this is important to you?

I note that yq is available via apt, I don't think it used to be.

yq/stable 3.1.0-3 all
  Command-line YAML processor - jq wrapper for YAML documents

@stasadev
Copy link
Member

stasadev commented Jun 11, 2024

There are two yq:
https://github.com/kislyuk/yq
https://github.com/mikefarah/yq - we use this one, it's better, because it has more features. I know this because I also use it outside of DDEV and I used to use https://github.com/kislyuk/yq at first but then switched to this one.

I think we could even pull the latest version, similar to Mailpit:

-ENV YQ_VERSION=v4.30.5
-RUN url="https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_${TARGETPLATFORM#linux/}"; wget ${url} -O /usr/bin/yq && chmod +x /usr/bin/yq
+RUN url="https://github.com/mikefarah/yq/releases/latest/download/yq_linux_${TARGETPLATFORM#linux/}"; wget ${url} -O /usr/bin/yq && chmod +x /usr/bin/yq

@rfay
Copy link
Member

rfay commented Jun 11, 2024

Getting latest works for me.

@stasadev
Copy link
Member

@juanjol, please update this PR with my suggestion, I think you will be happy to have the latest yq with every new DDEV release.

After that, we will push the new Docker images and update versionconstants.go.

@juanjol
Copy link
Contributor Author

juanjol commented Jun 11, 2024

Hi @stasadev, @rfay, thank you for your quick feedback! The main reason to update yq is to have a version that is capable of output yaml contents in a shell compatible mode. I would like to add a custom yaml config inside .ddev folder to keep some configs relate to our custom environments but not to ddev. I like the idea of always have the latests versions, so I updated this PR.

@rfay
Copy link
Member

rfay commented Jun 11, 2024

One request for the future @juanjol - Please don't use your fork's master branch for a PR. It means that you are stuck with it, and if you push anything else into it, it makes a mess of the PR. Instead, please use a meaningful branch name that is devoted to the PR (something like 20240611_juanjol_short_description, as is described in https://ddev.readthedocs.io/en/stable/developers/building-contributing/#pull-requests-and-pr-preparation

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 12, 2024
@rfay
Copy link
Member

rfay commented Jun 12, 2024

I pushed the images and updated the versionconstants.go

Copy link

@rfay rfay merged commit bf66cf3 into ddev:master Jun 12, 2024
20 of 21 checks passed
@juanjol
Copy link
Contributor Author

juanjol commented Jun 12, 2024

Thank you very much, understood! Sorry for the inconvenience, the truth is that I did it directly editing in github without downloading the repo and it was not the best idea.

Thanks again for the quick response and for the advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants