-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump yq to v4.44.1 #6299
Conversation
Just changing it here doesn't make it actually change. A new image has to be pushed and be referred to in the versionconstants.go. Can you say why this is important to you? I note that
|
There are two I think we could even pull the latest version, similar to Mailpit: -ENV YQ_VERSION=v4.30.5
-RUN url="https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_${TARGETPLATFORM#linux/}"; wget ${url} -O /usr/bin/yq && chmod +x /usr/bin/yq
+RUN url="https://github.com/mikefarah/yq/releases/latest/download/yq_linux_${TARGETPLATFORM#linux/}"; wget ${url} -O /usr/bin/yq && chmod +x /usr/bin/yq |
Getting latest works for me. |
@juanjol, please update this PR with my suggestion, I think you will be happy to have the latest After that, we will push the new Docker images and update |
Hi @stasadev, @rfay, thank you for your quick feedback! The main reason to update yq is to have a version that is capable of output yaml contents in a shell compatible mode. I would like to add a custom yaml config inside .ddev folder to keep some configs relate to our custom environments but not to ddev. I like the idea of always have the latests versions, so I updated this PR. |
One request for the future @juanjol - Please don't use your fork's |
I pushed the images and updated the versionconstants.go |
Download the artifacts for this pull request:
See Testing a PR. |
Thank you very much, understood! Sorry for the inconvenience, the truth is that I did it directly editing in github without downloading the repo and it was not the best idea. Thanks again for the quick response and for the advice. |
The Issue
yq yaml parser has a new version with multiple improvements
How This PR Solves The Issue
bump version to the latests stable release (v4.44.1)
Manual Testing Instructions
install ddev with this PR and launch yq --version inside web container. Version should be v4.44.1.
Automated Testing Overview
None
Release/Deployment Notes
None