Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use mysql:8.0 instead of mariadb for ExpressionEngine quickstart #5965

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ssssct
Copy link
Contributor

@ssssct ssssct commented Mar 13, 2024

The Issue

Even if mariadb works, there are times that specific joins can be much slower than in mysql.

How This PR Solves The Issue

ExpressionEngine documentation (and team) recommends using mysql instead of the default mariadb.

Even if mariadb works, there are times that specific joins can be much slower than in mysql. ExpressionEngine documentation (and team) recommends using mysql instead of the default mariadb.
@ssssct ssssct requested a review from a team as a code owner March 13, 2024 16:29
@rfay rfay changed the title Use mysql instead of mariadb for ExpressionEngine quickstart docs: Use mysql instead of mariadb for ExpressionEngine quickstart Mar 13, 2024
@rfay
Copy link
Member

rfay commented Mar 13, 2024

Yay, first PR!!! 💯 🥇

@rfay rfay changed the title docs: Use mysql instead of mariadb for ExpressionEngine quickstart docs: Use mysql:8.0 instead of mariadb for ExpressionEngine quickstart Mar 13, 2024
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on first PR! When there are some docs on the "why" for mysql:8.0 (since nothing like that is currently in EE docs) please update the OP with a link, thanks.

@rfay rfay merged commit dd85188 into ddev:master Mar 14, 2024
14 of 16 checks passed
@rfay
Copy link
Member

rfay commented Mar 14, 2024

You can still update the PR here at your convenience, maybe when your PR upstream goes in. Thanks for updating!

@ssssct
Copy link
Contributor Author

ssssct commented Mar 15, 2024

Great! Will do! Thanks Randy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants